Support PHP 8 #61
Merged
Support PHP 8 #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TavoNiievez
reviewed
Nov 26, 2020
| @@ -12,7 +12,7 @@ | |||
| ], | |||
| "minimum-stability": "RC", | |||
| "require": { | |||
| "php": ">=7.0.8 <8.0", | |||
| "php": ">=7.0.8 <9.0", | |||
There was a problem hiding this comment.
Compatibility with php 8.0 does not guarantee compatibility with 8.1+ .
I personally would have blocked it at <8.1. But I've seen that that was the way to add PHP8 support elsewhere in Codeception.
There was a problem hiding this comment.
I'm not doing this every year 😄
There were no compatibility issues with 8.0 in module code across all modules, so I have high expectations for 8.1 too.
TavoNiievez
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All dependencies actually work on PHP8, some of them just haven't updated version requirement in their composer.json